Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8290164: compiler/runtime/TestConstantsInError.java fails on riscv #95

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Nov 26, 2022

Please review this backport to jdk19u. Backport of JDK-8290164.
Applies cleanly. Approval is pending.

Testing:

  • compiler/runtime/TestConstantsInError.java passed

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290164: compiler/runtime/TestConstantsInError.java fails on riscv

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/95/head:pull/95
$ git checkout pull/95

Update a local copy of the PR:
$ git checkout pull/95
$ git pull https://git.openjdk.org/jdk19u pull/95/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 95

View PR using the GUI difftool:
$ git pr show -t 95

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/95.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2022

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3471ac9a907780d894d05bd58cf883c4c8d8838d 8290164: compiler/runtime/TestConstantsInError.java fails on riscv Nov 26, 2022
@openjdk
Copy link

openjdk bot commented Nov 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 26, 2022

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290164: compiler/runtime/TestConstantsInError.java fails on riscv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 998a6f5: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread
  • 0959a65: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 26, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2022

Webrevs

@feilongjiang
Copy link
Member Author

Got fix-request-yes, then
/integrate

@RealFYang
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@feilongjiang
Your change (at version c020905) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Nov 28, 2022

Going to push as commit 7a3b69a.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 998a6f5: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread
  • 0959a65: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2022
@openjdk openjdk bot closed this Nov 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@RealFYang @feilongjiang Pushed as commit 7a3b69a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants